unbridled-41 commented on PR #4559: URL: https://github.com/apache/rocketmq-dashboard/pull/4559#issuecomment-5746350238
## Verification evidence **CI (current head)**: this PR's head SHA `0057bd5b0c2b2aa162abbb4bec966b78419ad428` has exactly one workflow run — "CI" (pull_request), run id 35478298552, conclusion `startup_failure`, and 0 check-runs / 0 statuses on the head commit. Upstream's CI workflow fails at startup for **every** branch and PR in this repository (including maintainers'), i.e. no PR gets CI execution; local verification below substitutes for it. **Red (baseline source, new tests kept)**: restored `origin/master`'s `web/src/pages/cluster/index.tsx` while keeping the new test file, then `npx vitest run src/pages/cluster/__tests__/ClusterPage.test.tsx --testTimeout 60000` → `Test Files 1 failed (1)`, `Tests 6 failed | 23 passed (29)`. Failures are the new/updated assertions (payload still carrying `instanceId`, diff calls carrying the route instance). **Green**: same command with the fix → `Test Files 1 passed (1)`, `Tests 29 passed (29)`. **Type check / lint / build**: `npx tsc -b` exit 0; `npx eslint src/pages/cluster/index.tsx src/pages/cluster/__tests__/ClusterPage.test.tsx` exit 0; `npm run build` → `✓ built in 9.83s`. **Full web suite**: `npx vitest run --testTimeout 60000` → 1037 tests, 2 failed test files / 4 failed tests, all in files this PR does not touch (ConsumerPage ×2, MetricsExplorer, NotificationDeliveries — the load-fragile set recorded in prior rounds); running those three files in isolation → **62/62 passed**, confirming load fragility rather than a regression. Full-suite totals on this branch: 1037 tests (upstream master 1032 + 5 net new/updated regression assertions). **Diff self-check**: `git show --numstat 0057bd5b` → `web/src/pages/cluster/index.tsx +11/−3`, `web/src/pages/cluster/__tests__/ClusterPage.test.tsx +113/−9`. Two files, no unrelated changes; the −3/−9 are the previous route-instance expectations the fix replaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
