unbridled-41 commented on PR #4564:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4564#issuecomment-5747176448
## Verification evidence
**CI (current head)**: head SHA `7b629bce` — this PR's head has exactly one
workflow run, "CI" (pull_request), conclusion `startup_failure`, 0 check-runs /
0 statuses (same for every branch and PR in this repository, including
maintainers'; infrastructure-level, not caused by this change). Local
verification below substitutes for it.
**Red (baseline = master `d50ffecc` + the two new tests, fix stashed)**:
- `keeps the applied search visible in the input after the drawer is closed
and reopened` — failed at `expect(input).toHaveValue('order-1')`: received `''`
(the reopened input was empty while `listMessageQueryHistory` kept being called
with `search: 'order-1'`).
- `applies a cleared search field as an empty filter` — failed before the
fix because the input was uncontrolled (allowClear cleared the DOM but the
applied filter survived; and with my first controlled variant the draft could
not be cleared — the final draft-model design fixes both).
- Suite: `Tests run: 6, failed: 2` → `2 failed | 4 passed`.
**Module (green)**: `npx vitest run
src/components/__tests__/MessageQueryHistoryDrawer.test.tsx` → **6/6 passed**.
**Full suite + baseline**: clean run on this branch (no concurrent
processes): **1036 tests (1034 pristine + 2 new), 6 failed** — failures only in
the pre-existing load-flaky family (`ClusterPage` ×1 timeout, `ConsumerPage`
×3, `TopicPage` ×2 timeouts), none in the touched component. Pristine
`origin/master` worktree measured the same rotating family (two pristine runs:
14 and 22 failures, all in
ConsumerPage/ClusterPage/TopicPage/AlertsPage/AclPage/MessagePage/MetricsExplorer/ClientsPage/AuditPage
— the same recorded flaky set). The touched file passes isolated (6/6) and in
the full run.
**Build**: `npx tsc -b` clean; `npx eslint
src/components/MessageQueryHistoryDrawer.tsx
src/components/__tests__/MessageQueryHistoryDrawer.test.tsx` 0 problems; `npm
run build` ✓ (built in 12.26s).
**Diff self-check (`git show --numstat HEAD`)**: `18/0
web/src/components/MessageQueryHistoryDrawer.tsx`, `79/0
web/src/components/__tests__/MessageQueryHistoryDrawer.test.tsx` — 2 files,
+97/−0, no unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
