unbridled-41 commented on PR #4590:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4590#issuecomment-5748377831
### Verification evidence
**CI** — this PR's head is `d36aa86dbd76cf5322de26402a88e36d4b204854`.
GitHub reports exactly one workflow run for it: `35496736999` `CI`
(`pull_request`) → `startup_failure` (2026-09-20T07:23:26Z); `check-runs` = 0
and the combined status is `pending` with 0 statuses. The repository's workflow
fails to start on every branch, including `master`'s own recent runs (`#4584`,
`#4586`, `#4588` opened today show the same), so the checks below were executed
locally.
```
$ gh api "repos/apache/rocketmq-dashboard/actions/runs?head_sha=d36aa86d..."
--jq '.workflow_runs[] | "\(.id) \(.name) \(.event) \(.conclusion)"'
35496736999 CI pull_request startup_failure
$ gh api "repos/apache/rocketmq-dashboard/commits/d36aa86d.../check-runs"
--jq .total_count
0
```
**Red-light (base source + new test)**
```
$ git checkout origin/master -- web/src/pages/studio/BrokerCluster.tsx #
d50ffecc
$ npx vitest run
src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx
FAIL src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx >
BrokerCluster instance scope > keeps the instance the user selected when the
display language changes
AssertionError: expected last "vi.fn()" call to have been called with [
'instance-2' ]
- Expected
+ Received
[
- "instance-2",
+ "instance-1",
]
❯ src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx:160:46
Test Files 1 failed (1)
Tests 1 failed (1)
```
**Module tests (with the fix)**
```
$ npx vitest run
src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx \
src/pages/studio/__tests__/BrokerCluster.test.tsx
Test Files 2 passed (2)
Tests 16 passed (16) (1 new + 15 existing, including the
stale-topology case)
```
**Full suite + baseline**
```
$ npx vitest run --maxWorkers=4 # branch head
Test Files 1 failed | 122 passed (123)
Tests 1 failed | 1034 passed (1035)
```
`1035 = 1034 (pristine origin/master) + 1 new test`. The single failure is
`ConsumerPage.test.tsx > keeps the latest client stack when an older request
resolves last` — a file this PR does not touch, and one of the load-fragile
cases on this repository (the same file fails intermittently on pristine
`master` under a full parallel run; two pristine runs earlier in this session
produced 14 and 22 such failures). Isolation run:
```
$ npx vitest run src/pages/instance/__tests__/ConsumerPage.test.tsx
Test Files 1 passed (1)
Tests 32 passed (32)
```
**Build**
```
$ npx tsc -b # clean (exit 0)
$ npx eslint src/pages/studio/BrokerCluster.tsx
src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx
# no output: 0 errors, 0 warnings
$ npm run build # ✓ built in 12.48s
```
Note on the new test file: it initially reached `tsc` with an untyped
`instanceFixture` whose `type: 'DIRECT'` widened to `string` and failed
`Instance['type']`; the committed version annotates the fixture as `Instance`
and imports the type, so `tsc -b` is clean.
**Diff self-check**
```
$ git show --numstat --format="" HEAD
5 1 web/src/pages/studio/BrokerCluster.tsx
165 0
web/src/pages/studio/__tests__/BrokerClusterInstanceScope.test.tsx
```
One commit, two files, no unrelated changes: the source diff replaces the
unconditional `setSelectedInstanceId(apacheInstances[0]?.name)` with the
guarded functional update used by the producer page, and the dependency list is
untouched (the effect still re-reads the list on a language change — only the
destructive write is removed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
