unbridled-41 commented on PR #4588:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4588#issuecomment-5748334908
### Verification evidence
**CI** — this PR's head is `898f68334d757fac1a84e3202ead3f1b9b251ce0`.
GitHub reports exactly one workflow run for it: `35496305423` `CI`
(`pull_request`) → `startup_failure` (2026-09-20T07:13:46Z); `check-runs` = 0
and the combined status is `pending` with 0 statuses. The repository's workflow
fails to start on every branch, including `master`'s own recent runs (the same
result appears for this repository's other PRs opened today), so the checks
below were executed locally.
```
$ gh api "repos/apache/rocketmq-dashboard/actions/runs?head_sha=898f6833..."
--jq '.workflow_runs[] | "\(.id) \(.name) \(.event) \(.conclusion)"'
35496305423 CI pull_request startup_failure
$ gh api "repos/apache/rocketmq-dashboard/commits/898f6833.../check-runs"
--jq .total_count
0
```
**Red-light (base source + new test)**
```
$ git checkout origin/master --
web/src/pages/settings/GeneralSettingsTab.tsx # d50ffecc
$ npx vitest run
src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx
FAIL src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx >
GeneralSettingsTab unsaved input > keeps unsaved notification edits when the
display language changes
Error: expect(element).toHaveValue(…)
Expected the element to have value:
https://oapi.dingtalk.com/robot/send?access_token=edited
Received:
https://oapi.dingtalk.com/robot/send?access_token=server
❯ src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx:108:21
Test Files 1 failed (1)
Tests 1 failed (1)
```
**Module tests (with the fix)**
```
$ npx vitest run
src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx \
src/pages/settings/__tests__/GeneralSettingsTab.test.tsx \
src/pages/settings/__tests__/SettingsPage.test.tsx
Test Files 3 passed (3)
Tests 9 passed (9)
```
**Full suite + baseline**
```
$ npx vitest run --maxWorkers=4 # branch head
Test Files 123 passed (123)
Tests 1035 passed (1035)
```
`1035 = 1034 (pristine origin/master) + 1 new test` — the same suite
reported `1038` earlier in this session while three other in-progress
regression files were in the tree, which cross-checks the 1034 baseline. The
default-parallel `npx vitest run` on this repository intermittently reports
failures in the load-fragile files (MetricsExplorer, ConsumerPage, ClusterPage,
TopicPage, InstancePage, AlertsPage, AuditPage, ClientsPage,
MessagePage/MessagePageAsyncState); the `--maxWorkers=4` run above is the
contention-free result, and none of those files is touched by this PR.
**Build**
```
$ npx tsc -b # clean (exit 0)
$ npx eslint src/pages/settings/GeneralSettingsTab.tsx
src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx
# no output: 0 errors, 0 warnings
$ npm run build # ✓ built in 11.82s
```
**Diff self-check**
```
$ git show --numstat --format="" HEAD
9 2 web/src/pages/settings/GeneralSettingsTab.tsx
110 0
web/src/pages/settings/__tests__/GeneralSettingsFormResidue.test.tsx
```
One commit, two files, no unrelated changes: the source diff adds the
`translationRef` declaration plus its sync effect, routes the load-failure
message through the ref, and drops `t` from the load effect's dependency list.
The ref is written from an effect, so `react-hooks/set-state-in-effect` remains
satisfied (eslint reports no findings on the file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
