Frun1na opened a new pull request, #4619:
URL: https://github.com/apache/rocketmq-dashboard/pull/4619
### Which Issue(s) This PR Fixes
- Fixes #ISSUE_ID_PLACEHOLDER
### Brief Description
The K8s certificate page (`web/src/pages/cluster/certs.tsx`) rendered every
column title, form label, placeholder, confirmation and toast in hard-coded
Chinese, so an English-UI user saw a mixed-language page. Route all visible
strings through the existing i18n infrastructure: the previously orphaned
`cert.*` keys are now aligned with the live page text and the missing keys were
added, all with both Chinese and English entries. The Chinese strings are
byte-identical to the previous hard-coded text, so nothing changes for
Chinese-UI users; a new English-localization test covers the translated UI.
### How Did You Test This Change?
```
cd web && npm run lint
✖ 12 problems (0 errors, 12 warnings) # all pre-existing warnings
cd web && npx vitest run # full frontend suite
Test Files 134 passed (134)
Tests 1226 passed (1226)
```
The existing page tests keep passing unchanged (Chinese defaults are
byte-identical), and the new `K8sCertsPage English localization` test renders
the page with the English language preference and asserts the translated
heading, button and column headers.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`feat:` / `fix:` /
`refactor:` / `chore:` / `docs:` / `perf:`)
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
