Frun1na opened a new pull request, #4621:
URL: https://github.com/apache/rocketmq-dashboard/pull/4621

   ### Which Issue(s) This PR Fixes
   
   Fixes #4621
   
   ### Brief Description
   
   The user management page (`web/src/pages/studio/UserManagement.tsx`) 
rendered every user-visible string in hardcoded Chinese — the page header, the 
non-admin banner, table column headers, role/status tags, the session drawer, 
both modals, filter placeholders/aria-labels, pagination summary, and all 
success/error messages — so an English UI showed Chinese text on this page.
   
   This PR routes all of those strings through the shared translation 
dictionary under a new `userMgmt.*` namespace, reusing existing `common.*` keys 
(status, actions, enabled/disabled, cancel, refresh, export) where they already 
exist. The Chinese wording is unchanged byte for byte, so existing assertions 
on the rendered Chinese text still pass; the session-status tags helper became 
a component so it can consume the i18n context. A new test renders the page 
with the stored language preference set to `en` and asserts the English 
headings, buttons, placeholder and column headers.
   
   ### How Did You Test This Change?
   
   ```
   cd web && npx tsc --noEmit                      # passes
   npx eslint src/pages/studio/UserManagement.tsx \
     src/pages/studio/__tests__/UserManagement.test.tsx src/i18n/translations.ts
                                                   # 0 errors, 0 warnings
   npx vitest run src/pages/studio/__tests__/UserManagement.test.tsx
                                                   # 11 passed
   npx vitest run                                  # 134 files, all passed
   ```
   
   The English test fails without the change (the page has no English text at 
all before this PR).
   
   ### Checklist
   
   - [x] Follows the project style guidelines
   - [x] Tests cover the change; full suite passes locally
   - [x] The commit message follows Conventional Commits
   - [x] No unrelated files are touched
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to