Frun1na opened a new pull request, #4625:
URL: https://github.com/apache/rocketmq-dashboard/pull/4625
### Which Issue(s) This PR Fixes
Fixes #4625
### Brief Description
`rmqctl/install.sh` and the release pipeline disagree on three things, so
the documented `curl | bash` install can never succeed against the artifacts
produced by `make package/release` (`scripts/package-release.sh`):
1. The script downloads `rmqctl_<version>_<os>_<arch>.tar.gz`, but the
pipeline publishes `rmqctl-<os>-<arch>-<version>.tar.gz` — the request 404s.
2. The pipeline's `.sha256` files reference that published name; even with a
manually renamed file, the `shasum -c` step would fail because the script saves
the download under the underscore name.
3. After extraction the script looks for `${tmp}/rmqctl/rmqctl`, while the
archive stores the binary at its root (next to `LICENSE`, `NOTICE` and the
completion scripts).
This PR aligns `install.sh` with the published contract: the released asset
name, the checksum verification against it, and the binary location inside the
archive.
### How Did You Test This Change?
End-to-end against real artifacts:
```
cd rmqctl
go build -o /tmp/rmqctl-fake/rmqctl-linux-amd64 main.go
bash scripts/package-release.sh /tmp/rmqctl-fake/rmqctl-linux-amd64 linux
amd64 1.2.3 "" /tmp/rmqctl-fake/artifacts
# → rmqctl-linux-amd64-1.2.3.tar.gz + .sha256, binary at archive root
```
Running the updated `install.sh` with `curl` stubbed to serve the local
artifact directory completes every stage — release detection, download,
`sha256sum -c` OK, extraction, install — and the installed binary runs. The
pre-PR script fails at the download step against the same artifacts (requests
the nonexistent `rmqctl_1.2.3_linux_amd64.tar.gz`).
### Checklist
- [x] Follows the project style guidelines
- [x] Verified end-to-end against artifacts produced by
`scripts/package-release.sh`
- [x] The commit message follows Conventional Commits
- [x] No unrelated files are touched
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
