lizhimins commented on PR #4389: URL: https://github.com/apache/rocketmq-dashboard/pull/4389#issuecomment-5755154902
Closing as a duplicate of #4383, which has been merged into `rocketmq-studio` as 40a8f6a. Both PRs answer #4346 with an in-dialog guidance block over the same three files (`web/src/i18n/translations.ts`, `web/src/pages/cluster/index.tsx` and the ClusterPage test). #4383 was opened first, and it is the one that covers the acceptance point raised in the issue — Studio connects to the address from the server side, so the address must be reachable from the Studio server — and it ships an English-locale regression test for the new strings. Issue #4346 has been closed as completed by #4383. Thanks for writing this up; the overlap is a triage delay on our side rather than anything wrong with your patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
