unbridled-41 commented on PR #4617: URL: https://github.com/apache/rocketmq-dashboard/pull/4617#issuecomment-5760943348
@lizhimins Thanks for catching the missed consumer — fixed in 36308a63 (branch rebased onto the current trunk `29a7d4ab`). **Root cause**: the first commit fixed where `issue.resource` is *matched* (`issuesForResource`) but not where it is *shown*: the issues table's Group/Topic column rendered the field verbatim, so cells read `Consumer:cg-order` while the identically-titled resource-summary column shows the bare name with the type on a second line. **Review addressed (option a)**: the `clients.tsx:632-635` render now strips the `type:` prefix and displays the bare group/topic name; the qualified key stays as the internal roll-up key, so `issuesForResource` and the resource summaries are untouched, and the two same-titled columns now agree. No data-structure change was needed. **New assertion**: a page-level regression renders the real diagnostics panel and asserts the issues table displays `cg-order` (not `Consumer:cg-order`) and `order-events` (not `Producer:order-events`), while the summary row for `cg-order` still shows `Consumer` on its secondary line with the correct rolled-up issue count. Red with the display fix stashed, green with it: ClientsPage **21/21**, diagnostics unit tests **7/7**; tsc/eslint/build clean. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
