beautyarbutin opened a new pull request, #4817:
URL: https://github.com/apache/rocketmq-dashboard/pull/4817

   ### Which Issue(s) This PR Fixes
   
   - Fixes #3161
   
   ### Brief Description
   
   Adds bounded per-message failure details to both DLQ resend paths. Each 
failed resend now reports its DLQ message ID, resolved target topic, and a 
concise normalized reason; responses retain the existing aggregate fields and 
cap details at 100 entries with a truncation flag.
   
   The DLQ page shows the same structured failure details for time-range and 
selected-message resends, with Chinese and English UI strings. The batch 
accounting also avoids double-counting messages when producer setup or 
lifecycle fails after partial processing.
   
   This reimplements the proposal from #3162 against the current 
`rocketmq-studio` branch. Thanks to @tju-yxq for the original report and 
implementation direction.
   
   ### How Did You Test This Change?
   
   - `cd server && mvn -B -ntp 
"-Dtest=RocketMQDLQProviderTest,DLQControllerTest" test` - 65 tests passed.
   - `cd web && npm test -- --run src/api/dlq.test.ts 
src/pages/instance/__tests__/DLQPage.test.tsx` - 30 tests passed.
   - `cd web && npm run build` - production build passed.
   - Targeted ESLint and Prettier checks passed with 0 errors (the existing 
Fast Refresh warning for `formatDateTime` remains).
   - `cd server && mvn -B -ntp test` - 3,147 tests ran; the full suite could 
not complete locally because MySQL-backed integration tests could not connect 
to a local MySQL instance, plus two unrelated Claude CLI provider tests failed 
under the local CLI. The focused backend suite above is green.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / 
`refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [x] New UI text has both Chinese and English entries under `web/src/i18n/`
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit 
checks) - full suite requires local MySQL; focused tests and Checkstyle pass
   - [x] New source files carry the ASF license header
   - [x] Documentation touched where behaviour changed (in-app failure-detail 
labels and truncation notice)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to