pilichoumao commented on PR #4550: URL: https://github.com/apache/rocketmq-dashboard/pull/4550#issuecomment-5771001503
Rebased onto `rocketmq-studio@4c697f07` to clear the conflict introduced by #4544 and #4468, both anticipated in the PR description. How this change fits the merged neighbors: - **#4544** (resolver three-state model): this PR still only *adds* the `discoverProxyAddresses(MQAdminExt, brokerAddress)` overload used by the client-list inventory path; it does not touch `resolveConsumerConnectionStatus` or the `-1` sentinel model, and the group-health surface stays #4544's. - **#4468** (producer scan surfacing): the consumer-merge path (`findConsumerConnections`) is a disjoint method; both landed side by side without semantic overlap. - The MVC regression test now mocks the `NameserverRegistryService` required by the newer `ClientService` constructor; its assertion is unchanged (selected NameServer path only, no default-instance fallback). Re-verification on the rebased commit: - Backend: `mvn -Dspring.profiles.active=dev package` — **3,154 tests passed, 0 Checkstyle violations**; targeted `RocketMQClientProviderTest` (39), `ProxyConsumerResolverTest`, consumer-group tests all green. - Frontend: `ClientsPage` + `clientConnectionDiagnostics` **27 tests passed**; `npm run build`, Prettier on touched files, `git diff --check` clean. The `protocolConfig` map is keyed by the enum names the API returns, consistent with #4741's convention. - Real-cluster smoke rerun (local Apache RocketMQ 5.5.0 NameServer/Broker/cluster-mode Proxy, Java gRPC SDK 5.0.7 + Remoting 5.5.0 consumers): `GET /api/clients?namesrvAddr=127.0.0.1:19876` shows `ProxySmokeGrpc` and `ProxySmokeRemoting` with `protocol`/`version` null and `language=Java`, while `DirectSmokeRemoting` keeps `Remoting`/`V5_5_0` — no regression on the direct path. Note the endpoint now requires the NameServer to be registered first (upstream boundary added after the original submission); the smoke registers it via `/api/nameservers/registry/create`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
