3219378872 opened a new pull request, #11233:
URL: https://github.com/apache/rocketmq/pull/11233
### Which Issue(s) This PR Fixes
Fixes #11232.
### Brief Description
A newly connected gRPC SimpleConsumer can be visible in group-based Proxy
Admin subscription queries but absent from topic-based queries until the broker
has a consumer offset for it. Topic-only group discovery previously consulted
only broker registrations/offsets, so it never reached the existing Proxy-side
connection merge for this group.
Include the Proxy consumer manager's topic groups in `resolveGroups`,
deduplicating them with the broker result. Existing broker discovery,
group-only requests, topic filtering, and discovery-error behavior remain
intact; a missing Proxy consumer manager keeps broker-only behavior.
### How Did You Test This Change?
- 117 relevant tests passed, including 9 new loopback gRPC regressions for
local registrations, a peer `RemoteChannel` registration, source deduplication,
broker-only groups, unrelated topics, combined filters, absent consumer
manager, and broker discovery errors. Checkstyle and SpotBugs passed in the
normal Maven lifecycle.
- Real local NameServer + Broker + cluster-mode Proxy, with official
`rocketmq-client-java:5.2.2` SimpleConsumer in a separate JVM. Before any
receive/ack, all four RPCs returned `OK`; the original implementation returned
one subscription by group and zero by topic for both List/Describe. The same
fixture with the fix returns one in all four queries.
- The live check asserts that the Proxy knows the group while the broker
registration index, offset index, and real MQAdminExt topic-group query are
empty. The live check uses one Proxy; peer replication is represented by the
`RemoteChannel` component regression, not claimed as a live multi-Proxy test.
```bash
mvn -B -ntp -pl proxy -am \
-Dtest=ProxyAdminTopicDiscoveryTest,ProxyAdminGrpcServiceTest,ProxyAdminAuthInterceptorTest,AdminModelConverterTest,DefaultAdminServiceTest,ProxyConfigTest
\
-Dsurefire.failIfNoSpecifiedTests=false test
```
[Raw test results, pinned SDK fixture, and original/fixed runtime
logs](https://github.com/3219378872/rocketmq/tree/d833c21553f74a6909c4c7a9534a0a57c7d94bac/contribution-evidence/proxy-admin-topic-discovery).
Validation used Temurin 8u504 and Maven 3.9.9. This is an isolated local
runtime test, not a production deployment or full-project test claim. Prepared
with Codex assistance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
