beautyarbutin opened a new pull request, #5195: URL: https://github.com/apache/rocketmq-dashboard/pull/5195
### Which Issue(s) This PR Fixes - Fixes #3150 ### Brief Description The Push/Pop selector was applied to the rows already loaded for the current page, while the pager total came from the unfiltered query. A matching group on a later page could therefore be hidden and the total could be wrong. The paged endpoint now accepts `subscriptionMode`. Apache metadata queries apply the mode predicate before database pagination, so the database count and returned rows describe the same filtered set. Providers without a database query use the compatible default implementation, which filters the complete provider result before slicing the page. The existing no-filter path remains unchanged. The Apache query follows the existing display mapping: `Pop` is case-insensitive, and null or legacy non-Pop values are treated as `Push`. The web page sends the selected mode to the endpoint and resets to page 1 when the mode changes. ### How Did You Test This Change? - Backend targeted tests passed for `ConsumerGroupControllerTest`, `MetadataServiceTest`, `RocketMQMetadataProviderTest`, and `InstanceProviderTest`. - Frontend consumer page, consumer service, and metadata API tests passed: 59 tests. - Added a frontend regression test for sending `subscriptionMode` and resetting pagination. - Server `mvn validate` passed with Checkstyle. - Frontend TypeScript compilation and Vite module transformation completed. The local production build stopped during the repository's license collection step because the local `node_modules` tree is missing `@lobehub/icons-static-svg/package.json`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
