unbridled-41 commented on PR #4561:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4561#issuecomment-5929096898
Thanks for the review — both mechanical items are fixed in d561ac2f:
1. `NotificationOutboxService` now logs the original exception before
rethrowing: `log.warn("test notification failed on channel {}: {}", channel,
error.getMessage(), error)` — the pattern used elsewhere in this class.
`BusinessException` has no cause-taking constructor (checked: only
`(HttpStatus, String)` and `(int, String)`), so the log line is the only place
the original stack trace survives, which also covers the bare-NPE `"Test
notification failed: null"` case you flagged.
2. The test is renamed to `messageFailureCarriesTheConfigurationReasonTest`
(`NotificationOutboxServiceTest.java:767`) — suffix only, no `testXxx` prefix.
`mvn -o test -Dtest=NotificationOutboxServiceTest` passes 26/26, checkstyle
clean.
On sequencing: understood — #5077 is still open at the moment of writing, so
I will rebase this branch onto `rocketmq-studio` right after it lands and push
the rebased result before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
