zmuxuny opened a new pull request, #5258:
URL: https://github.com/apache/rocketmq-dashboard/pull/5258
### Which Issue(s) This PR Fixes
Fixes #5257
### Brief Description
The pending custom-query regression derives its deferred response type from
a fixture whose labels are inferred as `{ cluster, node_id }`. The custom
result intentionally has a `query` label instead, so the project build fails
with TS2353.
Use the existing `MetricData` API type for that deferred response. Its
labels contract is `Record<string, string>`, matching `queryMetrics`. The
custom labels, language-switch assertions, and repeat-query/loading assertion
remain intact. No cast, type suppression, production code, dependency, or
workflow change.
### How Did You Test This Change?
On `rocketmq-studio@a460673f` with this patch:
- Before the patch, `npx tsc -b --force --pretty false` failed at
`MetricsExplorer.test.tsx:516` with TS2353. After the patch, the same full
project build-mode typecheck passed.
- `npx vitest run src/components/__tests__/MetricsExplorer.test.tsx
--maxWorkers=1`: **35 passed**.
- `npm run lint`: **0 errors, 10 existing warnings**. ESLint and Prettier
checks for the changed test file passed.
- `npm run license:test`: **4 passed**.
- `npm run build`: TypeScript and Vite completed; the final existing
frontend license gate still failed with `build artifact verification failed:
assets/index-CmcSwssD.js`. That separate failure is tracked in #5018, with
overlapping fixes #5019 and #5083. This PR does not claim a passing aggregate
build.
- `git diff --check`: passed. Independent review found no blocking findings.
Toolchain: Linux, Node.js 24.19.0, locked TypeScript 5.9.3. This is a
test-fixture typing correction; no full frontend-suite, backend, live-cluster,
browser E2E, or Docker pass is claimed. Remote CI is pending for head
`c01e87e7d2b2caec9699e620358ad34c1ca74d7a`.
AI assistance was used; the source contract, diff, compiler regression, and
test results were reviewed.
### Checklist
- [x] One coherent fix linked to a reproducible issue
- [x] Conventional Commit subject
- [x] Existing regression assertions and license header preserved
- [x] Build-mode typecheck and focused suite verified
- [x] Remaining upstream license-gate failure disclosed
- [ ] Full CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
