Frun1na opened a new pull request, #5301: URL: https://github.com/apache/rocketmq-dashboard/pull/5301
### Which Issue(s) This PR Fixes - Fixes #5300 ### Brief Description `isPrivateHost` only recognized literal IPs, so the "plain HTTP allowed for private-network Studio endpoints" support (#4855) did not cover the common case of an intranet **DNS name** (`http://studio.internal:8080`): `net.ParseIP` fails for hostnames and the URL was rejected. The host is now resolved and accepted only when **every** resolved address is loopback/RFC1918/link-local; unresolvable names and mixed public/private resolution stay on HTTPS. Resolution is stubbable for tests and bounded by a 2s timeout. Note: this intentionally widens the HTTP allowance relative to #4855 - flagging it in the PR for explicit maintainer review of the security posture. ### How Did You Test This Change? ``` go test ./internal/studio/ -count=1 # ok (new deterministic resolution stubs) go vet, gofmt clean; go test ./... green ``` --- Re-submission of #4946: the original PR was closed by the stale bot after 7 days without review activity, and GitHub now rejects reopening pull requests in this repository ("state cannot be changed"), so the same change is re-submitted rebased onto the current `rocketmq-studio` tip (`a460673f`). The original review thread stays available at #4946. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
