Frun1na commented on PR #4927:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4927#issuecomment-5936517823

   Extended the AI contract instead of leaving the warning implicit:
   
   - `MessageQueryDlqOutput` carries `truncated` / `failedQueueCount` for the 
message-detail mode (null for the group listing, dropped by `NON_NULL`), 
`message.yaml`'s outputSchema gained both, and 
`rmqctl/internal/catalog/catalog_gen.go` was regenerated with `make 
catalog-generate` (`make catalog-verify` passes).
   - New provider tests for a capped scan (`truncated = true`) and for a queue 
that fails to scan (`failedQueueCount = 1`), plus `DLQControllerTest` 
assertions that both fields reach the JSON, and the handler test now pins the 
forwarding through the tool boundary.
   - The drawer warning is the shared `InfoBanner` with zh/en entries rather 
than a warning `Alert`: the cap is by design, not a fault, and page-level notes 
go through `InfoBanner` per the project convention.
   - Both flags are reset on a failed load and when the drawer reopens, so a 
stale truncation banner cannot sit next to the error alert.
   
   Verification: `RocketMQDLQProviderTest`, `DLQControllerTest`, 
`MessageQueryDlqToolHandlerTest`, `ToolOutputSchemaContractTest`, 
`ToolCatalogTest` on the server, and the DLQ page vitest file (28/28).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to