Frun1na commented on PR #5087:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5087#issuecomment-5936518914
All five sub-14px sites in `MainLayout.tsx` are now 14px: the `kbdStyle`
base (also used by the search-panel caps), the search-result section title, the
search-panel footer, plus the avatar fallback letter and the search-result row
from the previous revision.
- The regression test asserts a numeric lower bound (`parseFloat(fontSize) <
14` for px values) instead of equality with `13px`.
- The copy in `MainLayout.test.tsx` is deleted; the real-antd file is the
only one, and it now opens the navigation search so the search panel's sizes
are on screen (the user menu alone left them untested).
- `useAuthStore.getState().login('tester', 1, false)` replaces the raw
`setState` that was a TS2353, and the dead `listInstances` stub is replaced by
mocking `getInstanceCapabilities` through the `vi.hoisted` shape
`MainLayout.test.tsx` uses.
If you would still rather take this as a fresh PR, I am happy to close this
one and open the follow-up with the same content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
