tju-yxq opened a new pull request, #5393:
URL: https://github.com/apache/rocketmq-dashboard/pull/5393
### Which Issue(s) This PR Fixes
- Fixes #5392
### Brief Description
Routes the producer page's seven remaining hardcoded English strings through
the translation table with new `producer.*` keys (zh + en):
- the query-form labels `INSTANCE` / `TOPIC` / `PRODUCER GROUP`,
- the instance selector placeholder `Select instance`,
- the `Client ID` and `Producer Group` table column titles,
- the "Select an instance before querying producer connections" error toast.
No other behavior changes; the page's 27 existing localized strings are
untouched.
### How Did You Test This Change?
```
cd web && npm test -- Producer.test.tsx --run
Test Files 1 passed (1)
Tests 17 passed (17)
```
One new test asserts the Chinese defaults render the form labels (实例 / Topic
/ 生产者组) and the client column header (客户端 ID) — the strings that used to leak
English. The 16 existing tests (query flows, stale-state resets, double-submit
guards, CSV export, language-switch scope retention) all pass unchanged.
```
cd web && npm run lint
✖ 10 problems (0 errors, 10 warnings) # all pre-existing warnings in files
this PR does not touch
```
```
cd web && npx tsc -b --force
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test` (one rendering regression test added)
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks) (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (no behavior change
beyond localization)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
