Loyal-Young opened a new pull request, #5366: URL: https://github.com/apache/rocketmq-dashboard/pull/5366
### Which Issue(s) This PR Fixes - Fixes #5364 ### Brief Description The Proxy page captured the request generation before starting its initial load, then restored `captured + 1` on cleanup. That equals the in-flight request's generation, so a response arriving after unmount could still run `applyProxyHome()` and persist a Proxy address. Cleanup now increments the *current* generation, invalidating whichever request is active when the page leaves. This is separate from the failed health-probe race covered by open PR #5256. ### Verification - New regression test failed before the fix: `getProxyTopology` was called after unmount, proving the old response entered `applyProxyHome()`. - `cd web && node node_modules/vitest/vitest.mjs run src/pages/studio/__tests__/Proxy.test.tsx --pool=threads --maxWorkers=1 --reporter=dot` — 16 tests passed after the fix. - `cd web && node node_modules/eslint/bin/eslint.js src/pages/studio/Proxy.tsx src/pages/studio/__tests__/Proxy.test.tsx` — passed. - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit --pretty false` — passed. - `git diff --check` — passed. ### AI Assistance AI assistance helped inspect the request-generation lifecycle and draft the unmount regression. I confirmed the test failed on the unmodified code, reviewed the one-line invalidation change, and ran the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
