youngkermit8-coder opened a new pull request, #5417:
URL: https://github.com/apache/rocketmq-dashboard/pull/5417

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5416
   
   ### Brief Description
   
   Reject indexed (`msgIds[]`, `msgIds[0]`, `msgIds.0`) or explicitly empty 
`msgIds` parameters on DLQ Excel export before invoking the export service. The 
service also rejects a directly supplied empty list. Omitted `msgIds` still 
means whole-window export, and repeated `msgIds=a&msgIds=b` still selects 
messages. This changes only selection validation, its regression tests, and the 
API documentation.
   
   ### How Did You Test This Change?
   
   - On the unmodified base, MockMvc regression tests exposed the 
indexed-selection behavior; a separate red run exposed `msgIds=` returning HTTP 
200 on an earlier candidate.
   - On this single-commit branch, `cd server && mvn -q 
'-Dtest=DLQControllerTest,DLQServiceTest,RocketMQDLQProviderTest' 
'-Dspring.profiles.active=dev' test` passed 96 tests (0 failures, 0 errors, 0 
skipped). Maven's validate phase ran Checkstyle.
   - A broader filtered `dev`/H2 run, `mvn -q 
'-Dtest=*,!ClaudeCodeAgentProviderTest' '-Dspring.profiles.active=dev' test`, 
was attempted twice. Each run executed 3313 tests with 0 assertion failures, 1 
error, and 4 skipped. Both errors were 
`ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` failing 
in H2 2.4.240 index metadata with `ConcurrentModificationException`, 
independently documented in #5302. This is **not** a green full-suite result. 
MySQL-backed full-suite, packaging, deployed HTTP/browser, and upstream CI were 
not verified.
   - The patch passes `git diff --check`; the worktree was clean before 
publication.
   
   ### Checklist
   
   - [x] One coherent change; unrelated fixes are not bundled.
   - [x] Signed-off commit uses a Conventional Commits subject.
   - [x] Regression tests added with `...Test` method names.
   - [x] No new UI text or source files requiring new translations or headers.
   - [x] API documentation updated for the behavior change.
   - [ ] The complete backend suite is green; the independent H2 error above 
remains.
   
   AI assistance was used in developing and testing this change. The diff and 
test evidence were reviewed locally; any review feedback will be addressed on 
this same PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to