The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/grafana-broker-count 
has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
fdff1e9a70b78eb97665bf1170e4b1e869d701e3 / unbridled-41 
<[email protected]>
fix(metrics): count brokers instead of timeseries on the overview dashboard

The bundled "RocketMQ Cluster Overview" dashboard renders a stat panel
titled "Broker Count" from

  count(rocketmq_messages_in_total{cluster="$cluster"})

rocketmq_messages_in_total carries both a broker and a topic label -- the
same dashboard derives its $broker and $topic template variables from exactly
that metric -- so count() returns the number of broker/topic series. A
two-broker cluster with 300 topics reports 600 brokers.

The panel next to it, "Total Topics", already counts with the
count(count by (topic) (...)) idiom, so the intent is unambiguous.

Fix: count(count by (broker) (rocketmq_messages_in_total{cluster="$cluster"}))
in the generator, with the checked-in dashboard JSON regenerated from it.

Tested: server/scripts/test_gen_grafana_dashboards.py
(red on the old expression, green after); regenerating all 12 dashboards
reproduces the checked-in resources byte for byte.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37085935309

With regards,
GitHub Actions via GitBox

Reply via email to