The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/dlq-resend-ownership 
has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
46f2855d0d07385d77bd8cb94587dd592d65cc6a / unbridled-41 
<[email protected]>
fix(dlq): gate a resend on the ownership of the group and the target topic

DLQService only checked the instance's vendor before delegating, so any Apache
instance registered against the same cluster could read and replay another
instance's dead letters: the DLQ topic %DLQ%<group> belongs to the group's
owner, and an explicit targetTopic is a topic write of its own. Every sibling
write (sendMessage, redeliverMessage, resetOffset, consumeMessageDirectly) goes
through ResourceOwnershipGuard for exactly these resources; the DLQ resend
paths were the only ones left without it.

Wrap both resend entry points in ResourceOwnershipGuard.withOwned for the GROUP
resource (which is how the guard represents %DLQ%<group>) plus the TOPIC
resource when a target is named, so a foreign resource answers 409 before any
message is read or published.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37095261648

With regards,
GitHub Actions via GitBox

Reply via email to