zjncs opened a new pull request, #5538:
URL: https://github.com/apache/rocketmq-dashboard/pull/5538
## Problem
Four **live** backend operations are missing from the audit presentation
catalog (`web/src/pages/ops/auditPresentation.ts`), so their audit rows lose
the localized label (`labelKey` stays `undefined`), color and category (fall to
grey `other`) in the audit feed and the risk-insights "top operations" view:
| Operation | Backend site |
|---|---|
| `CREATE_ALERT_SILENCE` | `AlertSilenceService.java:75` |
| `DELETE_ALERT_SILENCE` | `AlertSilenceService.java:88` |
| `UPDATE_GROUP_SETTINGS` | `RocketMQAdminClientImpl.java:741,755,759` |
| `IMPORT_CLOUD_INSTANCES` | `InstanceService.java:358` |
The `ALERT_SILENCE` resource type is missing too (silence rows show a
title-cased fallback instead of the localized resource label).
Verified by a mechanical diff of the backend `record("...")` literals
against the catalog map (scout evidence), plus a failing test on each entry
(below).
## Fix
- Add the four operation entries with colors/categories consistent with
their families (alerts / metadata / instance) and `zh`/`en` translations;
- Add the `ALERT_SILENCE` resource entry + translation.
## Verification
New test `presents the alert-silence, group-settings and cloud-import audit
operations`:
- **before**: **1 failed** — all four operations resolve to `category:
'other'` with `labelKey: undefined`, `ALERT_SILENCE` resource falls back;
- **after**: **11/11** in `auditPresentation.test.ts` (the new test passes;
all 10 existing including the title-case fallback contract unchanged);
- **mutation** (revert the two source files): back to 1 failed; restore:
11/11.
```bash
cd web && npx vitest run src/pages/ops/__tests__/auditPresentation.test.ts
```
Note: #5524 adds `REVEAL_*` entries to the same map (different entries,
adjacent hunks) — this PR completes the catalog from the backend side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
