zjncs opened a new pull request, #5670: URL: https://github.com/apache/rocketmq-dashboard/pull/5670
### Problem `GroupDetailOutput` — the aggregated describe/progress/clients output of the AI group-detail tool (decision 11: the former describe output plus the blocks of two deleted tools) — had **no test**. ### Change Add `GroupDetailOutputTest` with ten tests pinning: | Contract | Pinned behaviour | | --- | --- | | name fallback | a blank source name falls back to the requested group | | retryMaxTimes | exposed **only** in the single-configuration case (null otherwise — ambiguous across groups) | | progress lag | sums across queues; one unknown-lag (`-1`) queue poisons the whole total to `-1` — unknown is not zero | | topic filter | applies to **both** the progress and clients blocks; a client matches through its `topicLag` map even without a subscription list | | empty-not-null | without data, progress/clients/subscriptions/instances stay empty lists, never null | | dirty lists | null entries inside instance/subscription lists never reach the mapping | | rendering | protocol null → `UNKNOWN`; heartbeat stringified; null collections default to empty | | availability | an unavailable connection inventory reports `onlineInstances` as `-1` | ### Verification - New tests: **10/10 green** against unmodified code. - Discriminating mutations on `GroupDetailOutput` (build result verified): unknown-lag queue summed as if known (**red**); topic filter dropped from the clients block (**red**); blank name no longer falls back (**red**); retryMaxTimes exposed unconditionally (**red**). - Restored: 10/10 green. No product code changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
