The GitHub Actions job "Coverage" on rocketmq.git/fix/mq-version-negative-value 
has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
78d15da573394ae3ac76ed2df90606f1f7be8b80 / zjncs <[email protected]>
fix(common): fall back to the higher version for negative version values

getVersionDesc and value2Version only guarded the upper bound, so a
negative version indexed VERSION_VALUES[-1] and threw
ArrayIndexOutOfBoundsException. The remoting header decodes the version
field as a signed short (RocketMQSerializable.readShort), so a peer
sending 0xFFFF produces -1, and namesrv broker registration
(DefaultRequestProcessor) calls value2Version on that wire-controlled
value. Mirror the upper-bound guard and clamp negatives to the last
entry, consistent with the existing unknown-version semantics.

Signed-off-by: zjncs <[email protected]>

Report URL: https://github.com/apache/rocketmq/actions/runs/34186606215

With regards,
GitHub Actions via GitBox

Reply via email to