The GitHub Actions job "Build and Run Tests by Maven" on 
rocketmq.git/fix/consumer-running-info-missing-properties has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
5a23fd07ddbeb7e78d2f8f87077b096da845b80d / zjncs <[email protected]>
fix(remoting): tolerate missing properties in ConsumerRunningInfo analyze 
methods

The static analyze helpers of ConsumerRunningInfo consume data reported
by each consumer over the wire, so the well-known properties cannot be
assumed to exist:

- analyzeSubscription turns an absent PROP_CONSUMER_START_TIMESTAMP into
  the string "null" via String.valueOf and dies with
  NumberFormatException (For input string: "null"), aborting
  mqadmin consumerStatus midway.
- isPushType and the inlined copy in analyzeProcessQueue cast the raw
  Properties.get() value to ConsumeType and dereference it, throwing
  NullPointerException when PROP_CONSUME_TYPE is absent.

Keep the startup grace when the start timestamp is unknown (the 2-minute
window exists to tolerate freshly started consumers, and an unknown
start time deserves the same grace), return false from isPushType when
the consume type is unknown, and reuse isPushType in analyzeProcessQueue
to remove the duplicated block.

Signed-off-by: zjncs <[email protected]>

Report URL: https://github.com/apache/rocketmq/actions/runs/34193895176

With regards,
GitHub Actions via GitBox

Reply via email to