pilichoumao commented on PR #5452: URL: https://github.com/apache/rocketmq-dashboard/pull/5452#issuecomment-6073669885
Thanks @lizhimins for the review. Addressed in a8be613a: - Renamed all six original test methods in `ConsumedTokenStoreTest` and `ToolTokenSingleUseTest` to end with `Test`; the two additional regression tests also follow this convention. - Reconciled the PR description to one full backend run on this branch based on `6a68042f`: **3,334 tests run, 0 failures, 0 errors, 3 skipped; BUILD SUCCESS; 0 Checkstyle violations** (Java 21, dev profile, `clean test`). - Also adopted your optional suggestion: `verifyAndConsume()` now runs after `preview()` succeeds and immediately before mutation execution. Regression tests cover a failed preview leaving the token usable for retry and a failed mutation keeping the token consumed. Concurrent applies still admit exactly one execution. [CI for this revision](https://github.com/apache/rocketmq-dashboard/actions/runs/37878626594) passes Backend Tests and rmqctl Build. The three build jobs fail at the license gates; the [unchanged base run at `6a68042f`](https://github.com/apache/rocketmq-dashboard/actions/runs/36893304649) has the same three failing jobs and the same license-gate error types. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
