lizhimins commented on PR #5231:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5231#issuecomment-6074065091
This pull request was closed by the stale bot on 2026-10-08 (seven days
without activity), not by a maintainer decision - the review below is what we
had queued for it.
Thanks for this. The core of it has since landed on `rocketmq-studio`: #4829
("share one message
timestamp formatter") already deleted both private formatters this PR
targets — `QueueBrowser.tsx`
now imports `formatTimeMs` from `utils/format` (line 38) and `message.tsx`
does the same (line 77),
with milliseconds kept. That is why the branch conflicts in three files and
why the new
`QueueBrowser.test.tsx` case targets a `describe('formatTimeMs')` block that
no longer exists there.
The remaining idea — labelling the viewer's zone on message instants — runs
against the format
#4829 pinned as console-wide (`format.ts:36-42` javadoc plus the
`$`-anchored shape regex in
`format.test.ts:103`). If you still want it, please open a fresh issue/PR
that adds a zone option to
the existing shared `formatTimeMs` and updates that pinned shape, rather
than introducing a second
formatter. We are treating this one as superseded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
