lizhimins commented on PR #5232:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5232#issuecomment-6074065736
This pull request was closed by the stale bot on 2026-10-08 (seven days
without activity), not by a maintainer decision - the review below is what we
had queued for it.
The substance is right — all 13 hardcoded Chinese literals in
QueueBrowser.tsx are real, and the
five keys you reuse (messagePage.topicPlaceholder/storeTime/size,
common.actions, common.view)
exist on trunk with byte-identical Chinese, so there is no zh regression.
Three things block it:
(1) The branch predates #4829 and #5023. `QueueBrowser.tsx` no longer
exports `formatTimeMs` (it
imports it from `utils/format`), and `QueueBrowserResults` now renders
`<MessageProperties>`
(lines 37, 386-388). Please rebase and keep both; your test file still
imports `formatTimeMs` from
`../QueueBrowser` and still has the `describe('formatTimeMs')` block that
#4829 moved to
`format.test.ts` — as-is that import resolves to undefined.
(2) `{entry.message.size} bytes` (line 363) stays hardcoded while #4834
added the shared
`formatBytes` that `message.tsx:833` already uses. Please route it through
`formatBytes`.
Also the description says 12/12 but the file yields 11 cases (8 `it` + one
3-value
`it.each`) — please correct the count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
