lizhimins commented on PR #5236:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5236#issuecomment-6074068069
This pull request was closed by the stale bot on 2026-10-08 (seven days
without activity), not by a maintainer decision - the review below is what we
had queued for it.
The four hardcoded strings are real (`dashboard.tsx:168-172` and
`index.tsx:505`) and there is no hook-dependency problem in the change. But
`dashboard.tsx` and `index.tsx` on this branch are byte-identical to the same
two files in #5329 (by @btlqql), so only one of the two can land; we will take
one of them and say which on the other.
What we would have asked you to fix regardless:
1. The footer version line has no assertion. Add one inside the
`describe('HomePage footer')` block of `HomePage.test.tsx` - under the en
locale, `getByText(/Current version .* build\(/)` plus an assertion that 当前版本
is absent - otherwise the `index.tsx:505` half of this change can be reverted
without reddening anything.
2. The description claims 16/16 cases; please reconcile it to what a single
run on the current base actually yields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
