lizhimins commented on PR #5233: URL: https://github.com/apache/rocketmq-dashboard/pull/5233#issuecomment-6074066360
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it. The code itself passes every gate we apply: the nine hardcoded Chinese strings are real, the keys line up with the dictionary, trunk's translations test already guards key existence, the branch merges cleanly against `rocketmq-studio`, and the three cases the description lists are the three the file has. Two things have to be settled first: 1. The description says #4803 was merged and later reverted by a branch fold. That is not what happened - #4803 (by @Wang1rrr) was never merged; the stale bot closed it. This branch is a near-verbatim resubmission of it. Please correct the description and the test comment, and say how the change came to you (rebased from the closed PR, or written independently). 2. Until that is settled we cannot merge it. Two byte-level identical patches from different authors, one of them closed by a bot, is exactly the case where taking the wrong one misattributes somebody's work. If you are in touch with the original author, the cleanest path is a single pull request that credits both of you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
