lizhimins commented on PR #5239:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5239#issuecomment-6074069255
This pull request was closed by the stale bot on 2026-10-08 (seven days
without activity), not by a maintainer decision - the review below is what we
had queued for it.
The coupling you found is real: `K8sCertService.java:93-94` formats the
validity window without a zone while `certs.tsx:188` renders it as UTC, and the
direction of the fix is right. Three things block it:
1. The backend case cannot fail on a UTC host, which is what CI runs on. Pin
the zone inside the test
(`TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))` with a
`try/finally` restore) so the assertion actually guards the change.
2. The frontend half has no coverage. Add a case for the two lines in
`certs.tsx` and use a fixture without an offset (e.g. `2027-01-01T00:00:00`) -
that is the only shape that tells `formatDateTime` and `formatUtcDateTime`
apart.
3. Say in the description what happens to already-stored `not_before` /
`not_after` values, and whether they need a one-off correction.
Note also that `certs.tsx` on this branch is byte-identical to #5511 (by
@zjncs), whose Java change is the same shape and whose tests are stronger, so
only one of the two can land. If you would rather not duplicate that work, item
3 is the part that is uniquely yours and the most useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
