123123213weqw opened a new pull request, #5766:
URL: https://github.com/apache/rocketmq-dashboard/pull/5766

   ## What
   
   `ProxyAddressService.buildTopology` / `previewReloadForInstance` hand the 
bracketed
   IPv6 literal from the registered address (`[::1]:8081`) straight to the 
health probe,
   which calls `new InetSocketAddress(host, port)` + `Socket.connect`. The 
bracket form
   is URI syntax only: `InetSocketAddress` cannot resolve `[::1]`, leaves the 
address
   unresolved, and the connect fails — so a reachable IPv6 proxy is always 
reported
   DOWN (or PARTIAL when the derived remoting port leaks through another form).
   
   ## Fix
   
   Strip the surrounding brackets before the host reaches the probe 
(`probeHost`).
   The registered address text and the reported `proxyAddr` keep their 
brackets; only
   the socket target loses them.
   
   ## Test
   
   `buildTopologyShouldProbeBracketedIpv6HostWithoutBrackets` registers 
`[::1]:8081`
   against a stubbed `ProxyHealthProbe` and asserts both probes are invoked 
with the
   unbracketed host (never the bracketed one) while the topology entry stays UP.
   Red on the current code (probe receives `[::1]`), green after the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to