123123213weqw opened a new pull request, #5773:
URL: https://github.com/apache/rocketmq-dashboard/pull/5773

   ## What
   
   `RocketMQClientProvider.findConnections` aggregates producer and consumer
   connection rows by walking the broker topology table (`brokerAddrTable`, a
   deserialized `HashMap`) and, per broker, each producer/consumer table (also
   hash maps). The output list therefore inherits hash-based iteration order and
   reshuffles between two snapshots of the same cluster, which makes the client
   list flicker and defeats any eyeball diffing of connections.
   
   ## Fix
   
   Sort the aggregated rows by a stable key — type, group/topic, clientId,
   address — before returning, so the client list is deterministic across
   snapshots.
   
   ## Test
   
   `connectionScanShouldReturnStableOrderAcrossTopologyChanges` feeds a topology
   whose broker table iterates in reverse-address order with one producer group
   per broker and asserts the rows come out group-ordered. Red on the current
   code (rows follow the table's iteration order), green after the sort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to