123123213weqw opened a new pull request, #5774:
URL: https://github.com/apache/rocketmq-dashboard/pull/5774

   ## What
   
   Both cluster providers build the `nameServers` rows of a `ClusterVO` by
   splitting the raw NameServer endpoint string and mapping every segment to a
   row. An endpoint that repeats a segment (`a:9876;b:9876;a:9876` — an easy
   copy-paste result) therefore shows the same NameServer node two or more times
   in the cluster detail, while `MqAdminExtFactory.normalizeNamesrvAddr` dedupes
   the very same string before connecting. The connection and the reported view
   disagree.
   
   ## Fix
   
   Deduplicate the trimmed segments (first occurrence wins, order preserved) in
   both `RealClusterProvider.toClusterVO` and
   `RocketMQClusterProvider.buildNameServerList`, so the rows match what the
   admin connection actually uses.
   
   ## Test
   
   `describeClusterShouldDeduplicateRepeatedNameServerSegments` and
   `discoverClustersShouldDeduplicateRepeatedNameServerSegments` feed endpoints
   with a repeated segment and assert each node appears once. Both red on the
   current code, green after.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to