lizhimins commented on PR #5428:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5428#issuecomment-6076046715
The wiring itself is right: MybatisPlusAclRepository.ruleQuery already had
the acl_version
predicate, the console sends '1.0'/'2.0' which matches both the stored value
(MybatisPlusAclRepository:365) and TencentAclService.ACL_VERSION, and
passing null from
AclListToolHandler is correct because rmq.acl.list's inputSchema has no
aclVersion.
Two things block it as-is:
1. The two @Test methods in the new AclRuleVersionFilterWebTest must end
with `Test`
(repo convention: ruleListShouldApplyTheAclVersionFilterToTheQueryTest,
...OpenWhenNoVersionIsRequestedTest).
New test files are held to this; existing files keep their own style.
2. GET /api/acl/rules gains a public query parameter, so
docs/api-spec.md:1243 and the
parameter table at :1248 need the aclVersion row.
Also worth a comment: the aclVersion("2.0") Tencent row in
listRulesShouldFilterTencentRulesByAclVersion cannot occur in production.
Please rename, add the doc row and re-push - no rebase needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
