zjncs commented on PR #5608:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5608#issuecomment-6077020110
Thanks @lizhimins — all three points addressed. The branch is rebased onto
rocketmq-studio c99b9ad5 and the PR has been retargeted.
1. **Trailing newlines restored** in both
`web/src/pages/ops/notificationDeliveries.tsx` and the new test file, so
lint-staged's prettier pass will no longer rewrite them. (FYI, the file does
carry one *pre-existing* prettier deviation on this branch — the long
`listAlertDeliveriesPage({ channel, status, instanceId, search, ...timeRange,
page, pageSize })` line #5034 introduced; I left it untouched to keep this diff
single-purpose, but can fold the reformat in if you'd rather the file be fully
clean.)
2. **The "Scout test:" note** now sits in its own `//` comment block below
the ASF license header instead of inside it, and the stray second space after
`(the "License");` is gone.
3. **Description corrected.** It no longer claims this was the sole
paginated ops list without the clamp; it now states the same gap exists in
`ops/systemAlerts.tsx`, `ops/ResourceOperationTimelineDrawer.tsx` and
`instance/dlq.tsx` (and notes the `pages/ai/hooks/useConversationList.ts`
instance was fixed in #5207). This PR stays single-purpose — only
`notificationDeliveries.tsx` — and I'm happy to follow up with the remaining
three as separate PRs if wanted.
Re-run on the rebased branch: the clamp test still fails with the clamp
reverted and passes with it (mutation check re-verified against the
#5034-reworked effect), the full file pair is 7/7 green (the existing page test
file grew to 6 tests with #5034's time-range cases), and `tsc --noEmit` plus
eslint are clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
