The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/topic-detail-load-failure has failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
d209e7502e32aa6cd07a32e0bfb56721325795dd / unbridled-41 
<[email protected]>
fix(topic): state what the sync check actually scanned

The 同步数据 dialog checks the routes of the topics on the current server page
but reports the result as an inventory-wide verdict: "所有 Topic 在 Broker
上均有路由,无需同步。" A topic missing its route on another page is therefore
declared healthy and cannot be synced from here.

Quote what was checked instead, and make the number mean what it says:

- Scan the rendered list (`filteredTopics`) rather than the raw page, so the
  count in the verdict covers exactly the rows the operator can see. Rows from
  another instance are still in state while an instance switch is in flight and
  the table hides them; counting them would quote topics nobody can see.
- Persist how many lookups succeeded and how many failed. Each route lookup is
  individually caught and recorded as `routes: null`, so `syncMissing` stays
  empty when lookups fail: without the counts the dialog would declare every
  topic verified after a run that verified none.
- Split the empty state. All verified keeps the scoped verdict with the
  verified count; any failure renders a durable error with a retry instead of a
  healthy claim, matching how the detail modal handles a failed route load. The
  transient `message.error` toast alone is gone before anyone reads the dialog.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37905015394

With regards,
GitHub Actions via GitBox

Reply via email to