The GitHub Actions job "Build and Run Tests by Maven" on 
rocketmq.git/fix/cold-data-flow-control-npe has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
d7821670091e1512a35ff62368f80374c5ccaa2b / zjncs <[email protected]>
[ISSUE #B3] Read the consume type from the compensation table in the cold-data 
flow-control path

The cold-data flow-control branch of PullMessageProcessor read the consume
type with ConsumerManager.getConsumerGroupInfo(group), which only sees the
live consumer table. Pull requests that carry their subscription (proxy /
lite-pull traffic) never registered the group there, so once the group is
flagged for cold-data flow control and the pulled offset is cold, the
processor dereferenced null and failed the request with an NPE.

The group's basic info (consume type, message model) is already
compensated into consumerCompensationTable a few lines earlier for exactly
these pull styles, so read it with getConsumerGroupInfo(group, true) like
ConsumerLagCalculator does, and fall back to the passive flow-control
response if even the compensation table has no record.

Signed-off-by: zjncs <[email protected]>

Report URL: https://github.com/apache/rocketmq/actions/runs/34338093826

With regards,
GitHub Actions via GitBox

Reply via email to