chennaji9 opened a new pull request, #11322:
URL: https://github.com/apache/rocketmq/pull/11322

   <!-- Please make sure the target branch is right. In most case, the target 
branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   Fixes #11316
   
   ### Brief Description
   
   Two factual corrections to the `DefaultMQProducer` API reference pages so 
they match the actual client behavior:
   
   1. **Retry counts vs attempts** 
(`docs/en/.../API_Reference_DefaultMQProducer.md:54-55`, 
`docs/cn/.../API_Reference_DefaultMQProducer.md:53-54`): the property tables 
described `retryTimesWhenSendFailed` / `retryTimesWhenSendAsyncFailed` as the 
"maximum number of internal attempts", but the synchronous send loop runs 
`timesTotal = 1 + getRetryTimesWhenSendFailed()` 
(`DefaultMQProducerImpl.java:756`) and the field Javadoc says "Maximum number 
of retry". With the default `2`, a sync send performs up to **3** attempts. The 
field sections of the same cn page already said this correctly 
("默认值:2,即:默认情况下一条消息最多会被投递3次"), so the tables contradicted the page itself. 
Tables now say retry count, total attempts = 1 + value.
   
   2. **Queue offsets are not physical offsets** (cn page, 
`maxOffset`/`minOffset`/`searchOffset` sections): these APIs are served by 
`getMaxOffsetInQueue`/`getMinOffsetInQueue`/`getOffsetInQueueByTime` and return 
the consume-queue **logical** offset, not a CommitLog physical byte offset. The 
物理偏移量 wording is replaced with 逻辑偏移量.
   
   ### How Did You Test This Change?
   
   Documentation-only change, verified statically against the PR base commit:
   - `timesTotal = 1 + getRetryTimesWhenSendFailed()` at 
`DefaultMQProducerImpl.java:756` (sync path); async retry counting analogous in 
`DefaultMQProducerImpl#invokeAsync`.
   - Field Javadoc at `DefaultMQProducer.java:129/136`: "Maximum number of 
retry to perform internally before claiming sending failure".
   - Offset methods dispatch to queue-offset broker RPCs 
(`AdminBrokerProcessor.java:1320/1388`), returning consume-queue indexes.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to