chennaji9 opened a new issue, #11314:
URL: https://github.com/apache/rocketmq/issues/11314

   ### Description
   
   Three documentation pages state that the default value of the broker/store 
configuration `useReentrantLockWhenPutMessage` is **false**:
   
   - `docs/en/Troubleshooting.md` (Performance section): "Adjust the Broker 
configuration item `useReentrantLockWhenPutMessage`, and the default value is 
false."
   - `docs/en/operation.md`: "a reentrant lock is recommended for synchronous 
disk flush, configuration item is `useReentrantLockWhenPutMessage`, default is 
false;"
   - `docs/cn/operation.md`: 
"同步刷盘建议使用重入锁,调整Broker配置项`useReentrantLockWhenPutMessage`,默认为false;"
   
   The actual default has been **true** since commit 5fe004168 ("Change default 
value of some parameters: 
sendMessageThreadPoolNums/useReentrantLockWhenPutMessage/...") merged on 
2021-05-13:
   
   ```java
   // 
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:166
   private boolean useReentrantLockWhenPutMessage = true;
   ```
   
   An operator reading these pages would conclude a stock broker uses the spin 
lock and that they must change the flag to get the reentrant lock — the 
opposite of the shipped behavior.
   
   ### Expected behavior
   
   The documentation should state the current default (`true`), consistent with 
`MessageStoreConfig`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to