The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/group-subscribed-topics has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
4fe3de45a48044e4c11fa28ef9e33156f6732c35 / unbridled-41 
<[email protected]>
fix(group): publish the subscribed topics of a listed group

The list path never filled the field:

    // toConsumerGroupVO / enrichGroupLiveStats: instances, onlineInstances, 
lag, delay only
    private List<String> subscribedTopics = new ArrayList<>();

while the sibling detail read fills it from the same connection
(RocketMQAdminClientImpl.getConsumerGroup). `enrichGroupLiveStats` already holds
the ConsumerConnection - it takes the instance list from it - but the group live
snapshot had no field for the subscription table, so every listed Apache group
shipped an empty list.

The consequences are user-visible on the list row itself: the detail drawer
renders the subscribed-topic count and the topic tags from it
(consumer.tsx: "订阅 Topic 数", the tag list), the CSV export has a column for it,
and the AI group detail emits `subscribedTopics: []` next to the subscription
entries it receives separately - all while the drawer's own 订阅关系 tab lists them.
The page never calls the detail endpoint, so nothing repaired the row.

Carry the topics through the snapshot (sorted, blank-filtered, empty meaning 
"not
read") and copy them onto the VO; an enrichment cut short by the batch deadline
leaves whatever the caller had rather than overwriting it with an empty list.

Tests (server/): mvn -o -B -ntp test -Dtest='RocketMQMetadataProviderTest' ->
Tests run: 49, Failures: 0, Errors: 0.
- new listConsumerGroupsPageShouldCarryTheGroupsSubscribedTopicsTest fails 
before
  this change (the row's list is empty) and passes after it.
- mvn -o -B -ntp test 
-Dtest='RocketMQMetadataProviderTest,MetadataServiceTest,ConsumerGroupControllerTest'
  -> Tests run: 131, Failures: 0, Errors: 0; checkstyle passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37984957412

With regards,
GitHub Actions via GitBox

Reply via email to