The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/verify-tab-trace-state has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
73af85d2f17781559a98576911463163388292b3 / unbridled-41 
<[email protected]>
fix(message): report a failed trace request on the verify tab too

The Trace and Verify tabs render the same payload (the trace modal fetches it
on entering either tab), but only the Trace pane renders the request's state:

    {traceLoading ? ... : traceError ? <Alert .../> : traceData?.nodes?.length 
? ... : 暂无轨迹数据}

The Verify pane binds just `traceData?.consumerStatus`:

    <Table dataSource={traceData?.consumerStatus?.map(...) || []} ... />

so a failed or still-running trace request renders antd's empty-table 
placeholder,
which reads as "no consumer group consumed this message" - the opposite of the
truth - and the only way to see the error is to switch to the Trace tab. The fix
that added the fetch for this tab (#4910) did not bring its request state along.

Render the same loading text and error alert on the Verify pane.

Tests (web/): npx vitest run 
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx 
src/pages/instance/__tests__/MessagePage.test.tsx
-> Tests 49 passed.
- new case "reports a failed trace request on the verify tab instead of an empty
  consumer table" fails before this change (nothing in the mounted pane) and 
passes
  after it.
- npx eslint reports no errors; npx tsc -b passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37984795011

With regards,
GitHub Actions via GitBox

Reply via email to