unbridled-41 opened a new pull request, #5975:
URL: https://github.com/apache/rocketmq-dashboard/pull/5975

   ### Which Issue(s) This PR Fixes
   Fixes #5974
   ### Problem / Evidence
   ```java
   // RocketMQMetadataProvider (before)
   AtomicReference<GroupLiveSnapshot> snapshot = new 
AtomicReference<>(GroupLiveSnapshot.empty());
   private static GroupLiveSnapshot empty() { return new 
GroupLiveSnapshot(List.of(), 0, false, 0L, 0, false); }
   ```
   `timedOutGroupEnrichmentMustNotMutateReturnedGroupTest` pinned the 
fabricated 0 in its two assertions; the same class sets -1 for a failed lookup 
and `ConsumerGroupVO` documents -1 as "inventory unavailable".
   ### Root cause / Fix
   "Nothing observed yet" doubled as a measured value. Initialize the snapshot 
with the sentinel (renamed `unknown()`); every worker-written snapshot is 
unchanged.
   ### Priority and scoring
   **PRIORITY 58** - impact 20/40 (a fabricated measurement that the health 
verdict escalates to critical), blast radius 12/20 (groups whose enrichment is 
cut short on a busy page), reproducibility 16/20 (pinned by the existing 
timeout test), maintenance value 10/20. **FIX_CONFIDENCE 78**.
   ### Tests
   `cd server && mvn -o -B -ntp test -Dtest='RocketMQMetadataProviderTest'` -> 
`Tests run: 48, Failures: 0, Errors: 0`; 
`-Dtest='MetadataServiceTest,ConsumerGroupControllerTest,RocketMQClientProviderTest'`
 -> `Tests run: 125, Failures: 0, Errors: 0`. The timeout test now asserts -1 
at both points and fails before the change (`expected: -1 but was: 0`); 
`checkstyle:check` passes.
   ### Risk
   Groups whose enrichment is cancelled now report the unknown sentinel (the 
web renders 不可用 and the diagnostics raise the "connection status unknown" 
warning instead of the critical "no clients with lag" claim).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to