The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/runtime-reminder-timestamps has failed.
Run started by GitHub user chennaji9 (triggered by chennaji9).

Head commit for run:
440e7497d8d886a11fefcb9d2ddb92c82654af22 / chennaji <[email protected]>
fix(alerts): omit reminder timestamps for non-reminding states

toRuntime projected nextReminderAt = lastNotifiedAt + reminderInterval
for every state that had ever notified, but the state machine only
emits REMINDER while FIRING with a positive interval: ACKED states
never remind again, RESOLVED keeps lastNotifiedAt as history, and a 0s
interval disables reminders outright. The runtimes view therefore
showed fabricated upcoming-reminder times, sometimes already in the
past.

Compute nextReminderAt only for FIRING states of a known rule with a
positive interval; every other state reports null.

Red-green: the new runtime projection test fails on the unfixed code
(ACKED, RESOLVED and 0s-interval rows all received timestamps) and
passes after; the repository suite (7) plus AlertServiceTest (83) and
AlertRuleControllerTest (22) stay green.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37965991942

With regards,
GitHub Actions via GitBox

Reply via email to