unbridled-41 opened a new pull request, #5999: URL: https://github.com/apache/rocketmq-dashboard/pull/5999
### Which Issue(s) This PR Fixes Fixes #5998 ### Problem / Evidence ```ts // messageService.listDLQGroups (mock branch, before) (group) => !search || group.groupName.includes(search) || group.dlqTopic.includes(search) ``` ``` messageService: matches the search term case-insensitively and trimmed, like the endpoint AssertionError: expected [] to include 'cg-order-processor' ``` The endpoint trims (`DLQService`) and lower-cases both sides (`RocketMQDLQProvider`); the sibling mocks already do the same. The DLQ pagination contract was aligned earlier (#5593), the search was not. ### Root cause / Fix A mock filter written before the endpoint's normalisation. Normalise the term once and compare lower-cased names. ### Priority and scoring **PRIORITY 55** - impact 14/40 (mock mode is the shipped demo default, so the discrepancy is user-visible), blast radius 10/20 (the DLQ list in mock mode), reproducibility 20/20 (pinned by the new test), maintenance value 6/20. **FIX_CONFIDENCE 90**. ### Tests `cd web && npx vitest run src/services/messageService.test.ts` -> `Tests 13 passed`; the new case fails before the change and passes after it; `npx eslint` and `npx tsc -b` are clean. ### Risk The mock now returns the rows the endpoint would; no production path changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
