unbridled-41 opened a new pull request, #6003: URL: https://github.com/apache/rocketmq-dashboard/pull/6003
### Which Issue(s) This PR Fixes Fixes #6002 ### Problem / Evidence The same validation block checks `reason` (512) and the labels, then writes `trimToNull(request.getInstanceId())` into `instance_id VARCHAR(128)` with no bound: ``` AlertSilenceServiceTest: createShouldRejectAnInstanceIdLongerThanItsColumnTest Expecting code to raise a throwable ``` ### Root cause / Fix Field-by-field bounding applied to two of three free-text fields. Bound `instanceId` with the same code-point rule (`TextBounds`) and fail with 400 before any write. ### Priority and scoring **PRIORITY 48** - impact 16/40 (an operator cannot tell that the silence was not created), blast radius 8/20, reproducibility 20/20, maintenance value 4/20. **FIX_CONFIDENCE 90**. ### Tests `cd server && mvn -o -B -ntp test -Dtest='AlertSilenceServiceTest,AlertSilenceControllerTest'` -> `Tests run: 15, Failures: 0, Errors: 0`; the new case fails before the change and passes after it, asserting no repository write; `checkstyle:check` passes. ### Risk Payloads longer than the column are now rejected earlier with 400. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
