unbridled-41 opened a new pull request, #6005:
URL: https://github.com/apache/rocketmq-dashboard/pull/6005

   ### Which Issue(s) This PR Fixes
   Fixes #6004
   ### Problem / Evidence
   `normalizeOptionalIdentity` only trims and rejects blanks; the derived 
issuer (`parsed.getIssuerX500Principal().getName()`) was written verbatim. 
Columns: `k8s_id`/`cluster` 128, `issuer` 256.
   ```
   K8sCertServiceTest: createCertShouldRejectAnIdentityLongerThanItsColumnTest
   Expecting code to raise a throwable
   ```
   ### Root cause / Fix
   Column widths were enforced only by the database. Bound caller-supplied 
identities with 400 (code points, the repo's rule) and bound the derived issuer 
to its column with a marker - refusing it would make the inventory unusable for 
a CA whose DN exceeds 256 characters.
   ### Priority and scoring
   **PRIORITY 45** - impact 14/40 (an unexplained 500; an unusable feature for 
long DNs), blast radius 8/20, reproducibility 18/20 (pinned by two new tests), 
maintenance value 5/20. **FIX_CONFIDENCE 78**.
   ### Tests
   `cd server && mvn -o -B -ntp test 
-Dtest='org.apache.rocketmq.studio.cluster.k8s.**'` -> `Tests run: 45, 
Failures: 0, Errors: 0`; the rejection case fails before the change and passes 
after it (asserting no save), and the truncation case pins 259 code points with 
the `...` marker and untouched short values; `checkstyle:check` passes.
   ### Risk
   A derived issuer longer than 256 characters is stored truncated with a 
marker (previously the registration failed).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to