The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/dlq-mock-search-contract has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
da4f0ddd5f11d471f5bd7a57d9812be6b1798094 / unbridled-41 
<[email protected]>
fix(web): make the mock DLQ search match its endpoint

The mock filtered with the raw term:

    (group) => !search || group.groupName.includes(search) || 
group.dlqTopic.includes(search)

while the endpoint trims the term (DLQService: search.trim()) and compares
case-insensitively (RocketMQDLQProvider: groupName.toLowerCase().contains(...)).
In mock mode - the default for the shipped demo config - a search for `ORDER`, 
or
for a padded ` order `, therefore returned nothing while the same search works 
in
production, and the DLQ page could not be exercised against its own fixture 
data.
The sibling mocks already lower-case their filters (topics, consumer groups, ACL
rules); this one was left behind. The DLQ pagination contract was aligned 
earlier
(#5593) but not the search.

Normalise the term once and compare lower-cased names.

Tests (web/): npx vitest run src/services/messageService.test.ts -t 
'case-insensitively'
- new case fails before this change (`expected [] to include 
'cg-order-processor'`)
  and passes after it; 13 tests in the file pass; npx eslint and npx tsc -b are 
clean.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37998307801

With regards,
GitHub Actions via GitBox

Reply via email to